make pip compile req file path relative to project #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran this locally and it all worked. I can't comment on the code itself but this also fixed the problem I have in https://github.com/ansible/docsite/pull/245/files#r1610634115 |
oraNod
force-pushed
the
noxfile-compile-rel-path
branch
from
44ad406 to
a6610f5
Compare
Merged
|
@felixfontein @gotmax23 can you give this one a quick review pls? I tried it locally and it works but I can't say much about the actual diffs :-) |
diff --git a/noxfile.py b/noxfile.py
index dac7a7a..bbe56d8 100644
--- a/noxfile.py
+++ b/noxfile.py
@@ -2,7 +2,7 @@ from pathlib import Path
import nox
-requirements_directory = Path("requirements").resolve()
+requirements_directory = Path("requirements")
requirements_files = [
requirements_input_file_path.stemwould have the same effect with less code. |
This change results in the paths of the output and input files relative to the project directory when pip-compiling requirements.
Co-authored-by: Maxwell G <[email protected]>
oraNod
force-pushed
the
noxfile-compile-rel-path
branch
from
a6610f5 to
0df5cab
Compare
felixfontein
approved these changes
May 23, 2024
|
Thanks @felixfontein and @gotmax23 for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change results in the paths of the output and input files relative to the project directory when pip-compiling requirements.